Thanks, @ahcorde !

Right now it's compiling but some of the tests are commented out

It's perfectly fine to disable tests on Windows for this first pass. We can just get it compiling first, and address other issues later.

What's left to open this PR for review? Is it just a general cleanup to make sure Linux and macOS are still working?

Codecov Report

Merging #120 (59af2e9) into main (fc1efd2) will decrease coverage by 0.84%.
The diff coverage is 23.07%.

@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
- Coverage   34.09%   33.25%   -0.85%     
==========================================
  Files           4        4              
  Lines         786      806      +20     
==========================================
  Hits          268      268              
- Misses        518      538      +20     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc1efd2...59af2e9. Read the comment docs.

@chapulina this is ready for review, but we should add the windows job.

@osrf-jenkins retest this please

Windows build should be fixed with this PR gazebosim/gz-transport#250

Niiice! It's building on Windows CI, it just has some warnings and failing tests, which I think can be addressed later.

We still need to fix macOS and DCO though.

I noticed a windows-related problem with the cmd*.rb files when I was testing gazebosim/gz-transport#216. The following lines have some logic for detecting when a string is an absolute or relative path based on whether it starts with /, but that is not valid logic for Windows, which has absolute paths that can start with C:\

https://github.com/ignitionrobotics/ign-launch/blob/main/src/cmd/cmdlaunch.rb.in#L33-L40

We can put this in an issue if you aren't planning to address the ruby code in this PR

We can put this in an issue if you aren't planning to address the ruby code in this PR

Let's do it to help with merging this as soon as possible to gain CI on Windows on other changes: #129

Compilation on Windows is working again, although tests needs attention.

LGTM! We can address the test failures later. DCO needs to be fixed.

I'll squash-merge the pull request and will set the right signed-off.